Update Snap Kit on Android to v2.1.0 #49
Conversation
|
@JonasWanke @TimmyRB |
|
Hey @JonasWanke thanks for the PR. We've tried implementing it in our project (especially due to your http upgrade). However, doing androi build, fails with: |
|
@simplenotezy That sounds like these four dependencies are still inside your module-level |
JonasWanke
changed the title
You were right, missed that. Thanks! |
|
By the way, not sure if you are using the "share link" functionality @JonasWanke - but did you notice that Snapchat silently removed support for this from day-to-day a few months back? All of a sudden our embedded links in shared posts wouldn't work and I noticed the same happened to bigger players such as BeReal and other apps using that feature. |
|
@simplenotezy No, I mostly focused on the Snapchat installation check and basic media sharing, which are the only things we're currently using |
|
@JonasWanke @TimmyRB are there any plans to review/merge this PR? It would make things a lot easier for folks that want to keep using this library for Snapchat integration. |
|
Hi @JonasWanke, thanks for the great work! I'm currently in the process recreating this package since so much has changed with both Flutter and the SnapSDK since I first created this plugin. I've merged your changes into If you'd like to test out the new version before it releases, you can do so like this in your project's snapkit:
git:
url: git://github.com/TimmyRB/snapkit.git
ref: snapkit-refresh-and-fixesThough it only contains new iOS and Dart code at this moment, I will update this comment when that changes. I have created PR #50 to track progress |
|
Quick update: I have updated the native Android side of things and the CreativeKit works great and adds sharing with video back to Android, however LoginKit isn't working at the moment for some unknown reason, I'm looking into it at the moment but Snapchat's error messages aren't exactly the most descriptive. |
5 participants
Closes: #40
The main change is that the native Android implementation now uses Snap Kit 2.1.0 instead of version 1.10.0. This is a breaking change because the meta-data tags in
AndroidManifest.xmlnow use different names. The Creative Kit in the provided example app works fine (after modifying the Android application ID and Snapchat client ID), but logging in didn't work for me. I only get a generic error dialog stating that an error occurred: “Something went wrong. Please try again.” Maybe you have an idea of why this isn't working?I added a changelog entry with a guide for users of this plugin. In addition, the wiki has to be updated:
BTW, I'd recommend changing the changelog's order from most recent to least recent, as that's far more common and users are likely most interested in the newer releases.
Additionally, I widened support for the http package since it recently had a new major release. The Dart code only contains minor modifications that made the code easier to read for me.